[webkit-reviews] review granted: [Bug 131916] iOS and non-iOS RemoteCommandListener::create() functions should use std::make_unique<>() : [Attachment 229770] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 131916: iOS and non-iOS RemoteCommandListener::create() functions should
use std::make_unique<>()
https://bugs.webkit.org/show_bug.cgi?id=131916

Attachment 229770: Patch
https://bugs.webkit.org/attachment.cgi?id=229770&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229770&action=review


I guess this is OK. It does seem slightly unsafe that the constructor is public
given that it would be incorrect to use it on iOS, but still better than a
“naked new”.

> Source/WebCore/platform/RemoteCommandListener.h:42
> +    RemoteCommandListener(RemoteCommandListenerClient& client) :
m_client(client) { };

No semicolon needed.