[webkit-reviews] review denied: [Bug 131921] [iOS] runtime application checks don't work in WebKit2 : [Attachment 229777] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 20 17:31:39 PDT 2014


Sam Weinig <sam at webkit.org> has denied Eric Carlson <eric.carlson at apple.com>'s
request for review:
Bug 131921: [iOS] runtime application checks don't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=131921

Attachment 229777: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=229777&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=229777&action=review


> Source/WebCore/page/Settings.h:275
> +    static void setEmbeddingApplicationBundleID(const String&);
> +    static const String& embeddingApplicationBundleID();

These don't seem like Settings things.	Why don't we just put all this in
RuntimeApplicationChecks.h/mm.


More information about the webkit-reviews mailing list