[webkit-reviews] review denied: [Bug 113285] document.createTouch crashes when document has no frame. : [Attachment 229646] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 19 14:37:26 PDT 2014


Darin Adler <darin at apple.com> has denied Miyoung Shin <myid.shin at samsung.com>'s
request for review:
Bug 113285: document.createTouch crashes when document has no frame.
https://bugs.webkit.org/show_bug.cgi?id=113285

Attachment 229646: Patch
https://bugs.webkit.org/attachment.cgi?id=229646&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
It is *not* good to store a Frame* in every event, which is what this patch
does. This looks like overkill. These helper functions don’t need to be put
into a class, and we really don’t want to get multiple inheritance and virtual
functions in the event classes just to do a bit more code sharing.


More information about the webkit-reviews mailing list