[webkit-reviews] review canceled: [Bug 131444] [CSS Shapes] Add support for shape-outside gradient values : [Attachment 229662] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 18 15:29:49 PDT 2014


Hans Muller <giles_joplin at yahoo.com> has canceled Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 131444: [CSS Shapes] Add support for shape-outside gradient values
https://bugs.webkit.org/show_bug.cgi?id=131444

Attachment 229662: Patch
https://bugs.webkit.org/attachment.cgi?id=229662&action=review

------- Additional Comments from Hans Muller <giles_joplin at yahoo.com>
I've made the checkShapeImageOrigin() StyleImage* parameter a const
StyleImage&.

I'll attempt to make this StyleImage function's RenderElement* parameter, const
RenderElement*, in a separate patch:

    virtual PassRefPtr<Image> image(RenderElement*, const FloatSize&) const =
0;


More information about the webkit-reviews mailing list