[webkit-reviews] review granted: [Bug 131799] [Mac] implement WebKitDataCue : [Attachment 229667] Another attempt

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 131799: [Mac] implement WebKitDataCue
https://bugs.webkit.org/show_bug.cgi?id=131799

Attachment 229667: Another attempt
https://bugs.webkit.org/attachment.cgi?id=229667&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229667&action=review


> Source/WebCore/html/track/InbandDataTextTrack.h:59
> +    virtual void removeCue(TextTrackCue*, ExceptionCode&) override;

Is this an override?

>
Source/WebCore/platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF
.cpp:33
> +#include "SoftLinking.h"

What are you SoftLinking here?

>
Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
32
> +#include "InbandMetadataTextTrackPrivateAVF.h"

You seem to include it here...

>
Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
43
> +class InbandMetadataTextTrackPrivateAVF;

... and forward declare it here.