[webkit-reviews] review granted: [Bug 131776] Find on page - extend API by providing highlighted match index : [Attachment 229661] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 18 14:26:02 PDT 2014


Tim Horton <thorton at apple.com> has granted Alice Liu
<alice.barraclough at webkit.org>'s request for review:
Bug 131776: Find on page - extend API by providing highlighted match index
https://bugs.webkit.org/show_bug.cgi?id=131776

Attachment 229661: Patch
https://bugs.webkit.org/attachment.cgi?id=229661&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229661&action=review


> Source/WebKit2/WebProcess/WebPage/FindController.cpp:136
> +	       if (pluginView)
> +		   matchCount = pluginView->countFindMatches(string,
core(options), maxMatchCount + 1);

I'm not sure this comment from last time got fixed (below) but I can't tell
because your patch doesn't let me expand context for some reason :D


More information about the webkit-reviews mailing list