[webkit-reviews] review granted: [Bug 131850] Options::maximumExecutionCountsBetweenCheckpoints() should be higher for DFG->FTL tier-up but the same for other tier-ups : [Attachment 229664] the patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 131850: Options::maximumExecutionCountsBetweenCheckpoints() should be
higher for DFG->FTL tier-up but the same for other tier-ups
https://bugs.webkit.org/show_bug.cgi?id=131850

Attachment 229664: the patch
https://bugs.webkit.org/attachment.cgi?id=229664&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229664&action=review


r=me after tests + perf numbers come back green :-)

> Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp:90
> +    default:
> +	   RELEASE_ASSERT_NOT_REACHED();

Some platforms might complain about clippedValue not being defined prior to use
here. You might want to set it to some bogus value in this branch.