[webkit-reviews] review denied: [Bug 131173] Web Inspector: add entries for probe samples in the JS/Events timeline UI : [Attachment 229597] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 17 17:37:55 PDT 2014
Timothy Hatcher <timothy at apple.com> has denied Katie Madonna
<madonnk at gmail.com>'s request for review:
Bug 131173: Web Inspector: add entries for probe samples in the JS/Events
timeline UI
https://bugs.webkit.org/show_bug.cgi?id=131173
Attachment 229597: Patch
https://bugs.webkit.org/attachment.cgi?id=229597&action=review
------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229597&action=review
Looking good. Missing the icon file.
> Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js:218
> + return WebInspector.UIString("Probe Sample Fired");
I think “Probe Sample Recorded” or “Probe Fired” would be better.
> Source/WebInspectorUI/UserInterface/Views/TimelineIcons.css:79
> + content: url(../Images/TimelineRecordProbeSampled.svg);
I don't see the icon added in the patch. Forget svn/git add?
More information about the webkit-reviews
mailing list