[webkit-reviews] review denied: [Bug 100632] Make RenderLayerBacking get the timingFunction of the correct animation. : [Attachment 229573] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 100632: Make RenderLayerBacking get the timingFunction of the correct
animation.
https://bugs.webkit.org/show_bug.cgi?id=100632

Attachment 229573: Patch
https://bugs.webkit.org/attachment.cgi?id=229573&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229573&action=review


> Source/WebCore/platform/graphics/GraphicsLayer.h:93
> -    RefPtr<TimingFunction> m_timingFunction;
> +    const TimingFunction* m_timingFunction;

I think this still needs to be a RefPtr. We have no guarantee that the
AnimationValue won't outlive whoever holds onto the TimingFunction*.