[webkit-reviews] review granted: [Bug 131779] On iOS keep network process running using a process assertion rather than a boost : [Attachment 229507] Fix

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 131779: On iOS keep network process running using a process assertion
rather than a boost
https://bugs.webkit.org/show_bug.cgi?id=131779

Attachment 229507: Fix
https://bugs.webkit.org/attachment.cgi?id=229507&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=229507&action=review


> Source/WebKit2/UIProcess/WebProcessProxy.h:225
> +    std::unique_ptr<ProcessAssertion> m_assertion;

Let's move this guy to ChildProcessProxy.

> Source/WebKit2/UIProcess/ios/ProcessAssertion.h:39
> +    enum State {

typed enum?

> Source/WebKit2/UIProcess/ios/ProcessAssertion.mm:36
> +const BKSProcessAssertionFlags BackgroundTabFlags =
(BKSProcessAssertionAllowIdleSleep);
> +const BKSProcessAssertionFlags ForegroundTabFlags =
(BKSProcessAssertionAllowIdleSleep | BKSProcessAssertionPreventTaskSuspend |
BKSProcessAssertionAllowSuspendOnSleep |
BKSProcessAssertionWantsForegroundResourcePriority |
BKSProcessAssertionPreventTaskThrottleDown);

Lowercase first letter for variable names.

We'll probably need something configurable for
BKSProcessAssertionPreventTaskThrottleDown on the WebProcess.

> Source/WebKit2/UIProcess/ios/ProcessAssertion.mm:59
> +    m_assertionState = assertionState;

Let's assign this before the out call in case some delegate cause us to
re-enter.