[webkit-reviews] review granted: [Bug 100632] Make RenderLayerBacking get the timingFunction of the correct animation. : [Attachment 229485] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 100632: Make RenderLayerBacking get the timingFunction of the correct
animation.
https://bugs.webkit.org/show_bug.cgi?id=100632

Attachment 229485: Patch
https://bugs.webkit.org/attachment.cgi?id=229485&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229485&action=review


> Source/WebCore/rendering/style/KeyframeList.cpp:30
> +const PassRefPtr<TimingFunction> KeyframeValue::timingFunction(const
AtomicString& name) const

This should return a raw cost TimingFunction*; it's not transferring ownership.


Also the function should be timingFunctionForAnimation().

> Source/WebCore/rendering/style/KeyframeList.cpp:38
> +	   if (name == keyframeStyle->animations()->animation(i).name())
> +	       return
keyframeStyle->animations()->animation(i).timingFunction();

Cache keyframeStyle->animations()->animation(i) in a variable.