[webkit-reviews] review denied: [Bug 100632] Make RenderLayerBacking get the timingFunction of the correct animation. : [Attachment 171163] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 100632: Make RenderLayerBacking get the timingFunction of the correct
animation.
https://bugs.webkit.org/show_bug.cgi?id=100632

Attachment 171163: Patch
https://bugs.webkit.org/attachment.cgi?id=171163&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171163&action=review


There looks like a logic error/dead code in your implementation of
timingFunction. Please fix! :-)

> Source/WebCore/rendering/style/KeyframeList.cpp:38
> +	       return keyframeStyle->animations()->animation(i) ?
keyframeStyle->animations()->animation(i)->timingFunction() : 0;

This looks wrong. We would blow up here if
!keyframeStyle->animations()->animation(i), so either this test isn't
necessary, or we need to be checking before we look at the name. Given that the
original code didn't do this, I think we can just omit the test.