[webkit-reviews] review denied: [Bug 124999] [Texmap] TextureMapperLayer unnecessary object copying : [Attachment 224737] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 16 14:08:53 PDT 2014
Brent Fulgham <bfulgham at webkit.org> has denied Przemyslaw Szymanski
<p.szymanski3 at samsung.com>'s request for review:
Bug 124999: [Texmap] TextureMapperLayer unnecessary object copying
https://bugs.webkit.org/show_bug.cgi?id=124999
Attachment 224737: patch
https://bugs.webkit.org/attachment.cgi?id=224737&action=review
------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=224737&action=review
Looks very go! Pleaseo switch to 'auto&', but otherwise this looks good.
> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:348
> + for (IntRect& rect : rects) {
Please make this for (auto& rect : rects) {
> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:367
> + for (IntRect& rect : rects) {
Ditto.
More information about the webkit-reviews
mailing list