[webkit-reviews] review requested: [Bug 130148] [GTK][CMAKE] build-webkit doesn't detect when the build fails : [Attachment 229476] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 16 13:44:23 PDT 2014


Brendan Long <b.long at cablelabs.com> has asked  for review:
Bug 130148: [GTK][CMAKE] build-webkit doesn't detect when the build fails
https://bugs.webkit.org/show_bug.cgi?id=130148

Attachment 229476: Patch
https://bugs.webkit.org/attachment.cgi?id=229476&action=review

------- Additional Comments from Brendan Long <b.long at cablelabs.com>
Here's a simpler one that just replaces -i with -k, so at least the error code
will be correct. I'm going to look into adding ninja-build to
install-dependencies. CMake doesn't do this with ninja by default, so if we can
auto-install ninja then most peope won't see this unless they want it.


More information about the webkit-reviews mailing list