[webkit-reviews] review granted: [Bug 131390] Support "Live" streams in media controls. : [Attachment 229154] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 131390: Support "Live" streams in media controls.
https://bugs.webkit.org/show_bug.cgi?id=131390

Attachment 229154: Patch
https://bugs.webkit.org/attachment.cgi?id=229154&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=229154&action=review


r=me, but I have some concerns about not seeing "Stalled..." and so forth
anymore!

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:486
> +	       this.controls.panel.appendChild(this.controls.statusDisplay);

Why don't we want the statusDisplay for fullscreen non-live controls case? It
looks like we do include it in the non-fullscreen case (see line 442)

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:-488
> -	   this.controls.statusDisplay.innerText = this.UIString('Aborted');

We don't seem to get this text in 'updateStatusDisplay"

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:-493
> -	   this.controls.statusDisplay.innerText = this.UIString('Suspended');

Ditto...

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:-498
> -	   this.controls.statusDisplay.innerText = this.UIString('Stalled');

Ditto...

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:-504
> -	   this.controls.statusDisplay.innerText = this.UIString('Waiting');

Ditto...