[webkit-reviews] review denied: [Bug 130534] Move cross-port Source/WebCore/page/ code to std::unique_ptr : [Attachment 227791] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 130534: Move cross-port Source/WebCore/page/ code to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=130534

Attachment 227791: Patch
https://bugs.webkit.org/attachment.cgi?id=227791&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=227791&action=review


This looks good, but unfortunately seemed to choke in the EWS system for Mac. 
Could you rebaseline and upload again so we can confirm it's okay?

> Source/WebCore/page/ContentSecurityPolicy.cpp:919
> +    std::unique_ptr<CSPDirectiveList> directives(new
CSPDirectiveList(policy, type));

Why not auto directives = std::make_unique<CSPDirectiveList>(policy, type)?