[webkit-reviews] review granted: [Bug 131693] [WK2] Move WebMouseEvent class to its own header file : [Attachment 229415] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 131693: [WK2] Move WebMouseEvent class to its own header file
https://bugs.webkit.org/show_bug.cgi?id=131693

Attachment 229415: Patch
https://bugs.webkit.org/attachment.cgi?id=229415&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229415&action=review


> Source/WebKit2/Shared/WebEventConversion.cpp:29
>  #include "WebEvent.h"

Should remove this line.

> Source/WebKit2/Shared/API/c/WKSharedAPICast.h:49
>  #include "WebEvent.h"

Should remove this line.

> Source/WebKit2/Shared/efl/WebEventFactory.h:29
>  #include "WebEvent.h"

Should remove this line.

> Source/WebKit2/Shared/gtk/WebEventFactory.h:30
>  #include "WebEvent.h"

Should remove this line.

> Source/WebKit2/Shared/mac/NativeWebMouseEventMac.mm:32
> +#import "WebMouseEvent.h"

This doesn’t seem right. Why do you need to add this include here?

> Source/WebKit2/Shared/mac/WebEventFactory.h:29
>  #import "WebEvent.h"

Should remove this line.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.h:32
>  #include "WebEvent.h"

Should remove this line.

> Source/WebKit2/WebProcess/Plugins/Plugin.h:29
> +#include "WebMouseEvent.h"

This doesn’t seem right. Why do you need to add this include here?

> Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp:42
>  #include "WebEvent.h"

Should remove this line.

> Source/WebKit2/WebProcess/Plugins/PluginView.cpp:33
>  #include "WebEvent.h"

Should remove this line.

> Source/WebKit2/WebProcess/WebPage/FindController.h:32
> +#include "WebMouseEvent.h"

This doesn’t seem right. Why do you need to add this include here?