[webkit-reviews] review granted: [Bug 131705] Fullscreen media controls are unusable in pagination mode : [Attachment 229448] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 131705: Fullscreen media controls are unusable in pagination mode
https://bugs.webkit.org/show_bug.cgi?id=131705

Attachment 229448: Patch
https://bugs.webkit.org/attachment.cgi?id=229448&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229448&action=review


> Source/WebCore/rendering/RenderFullScreen.h:44
> +    RenderBlock* ensurePlaceholder();
>      RenderBlock* placeholder() { return m_placeholder; }

We recently discussed this idiom on the WebKit mailing list. The coding style
we agreed on would be like this:

    RenderBlock& placeholder();
    RenderBlock* placeholderIfExists() { return m_placeholder; }