[webkit-reviews] review granted: [Bug 131631] [Win] Eliminate use of deleteAllValues in Windows Files : [Attachment 229426] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 131631: [Win] Eliminate use of deleteAllValues in Windows Files
https://bugs.webkit.org/show_bug.cgi?id=131631

Attachment 229426: Patch
https://bugs.webkit.org/attachment.cgi?id=229426&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229426&action=review


Great! I suggest landing this as is.

I think there’s a way to do this without declaring the StgMediumDeleter struct;
I think the type can just be a function pointer and we can use the
ReleaseStgMedium itself as the deleter. But I don’t think that additional
refinement is important enough to spend time on.

I also looked into the takeLast thing, and all we’d have to do is add a single
std::move to make it work with move-only types.

> Tools/DumpRenderTree/win/DRTDataObject.cpp:349
> +	       m_formats[position] = std::move(m_formats[m_formats.size() -
1]);

Could be m_formats.last() instead of m_formats[m_formats.size() - 1].