[webkit-reviews] review requested: [Bug 127835] ASSERTION FAILED: x2 >= x1 in WebCore::RenderObject::drawLineForBoxSide : [Attachment 229434] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 16 01:54:45 PDT 2014


Martin Hodovan <mhodovan.u-szeged at partner.samsung.com> has asked  for review:
Bug 127835: ASSERTION FAILED: x2 >= x1 in
WebCore::RenderObject::drawLineForBoxSide
https://bugs.webkit.org/show_bug.cgi?id=127835

Attachment 229434: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=229434&action=review

------- Additional Comments from Martin Hodovan
<mhodovan.u-szeged at partner.samsung.com>
Thank you for the review again!
I have extended the test to upper and bottom cases. However, it seems like we
can not make
the assert fail by simply manipulating the top and bottom padding and margin
values.
I created a reference test by setting the border color to white in cases where
the border
should not be displayed. I tried to set the border style to 'none' or 'hidden'
instead, but
it made the content box shift by a few pixel (the width of the border).


More information about the webkit-reviews mailing list