[webkit-reviews] review granted: [Bug 131553] Snapshotted plugins may need to be restarted if style properties are changed after initial load of plugin. : [Attachment 229326] patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Roger Fong <roger_fong at apple.com>'s
request for review:
Bug 131553: Snapshotted plugins may need to be restarted if style properties
are changed after initial load of plugin.
https://bugs.webkit.org/show_bug.cgi?id=131553

Attachment 229326: patch
https://bugs.webkit.org/attachment.cgi?id=229326&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229326&action=review


This is fine with me as long as the behavior is fine with Jon/Dean, but please
confirm.

> Source/WebCore/html/HTMLPlugInImageElement.cpp:609
> +    int contentWidth = contentRect.width();
> +    int contentHeight = contentRect.height();

why the temporaries? they're only used once below.

> Source/WebCore/html/HTMLPlugInImageElement.cpp:646
> +    if (!renderer()->isSnapshottedPlugIn()) {

if you move this above the previous block, you can get rid of that check in its
condition

> LayoutTests/plugins/snapshotting/set-plugin-size-to-tiny.html:15
> +	   testRunner.notifyDone()

semicolon