[webkit-reviews] review granted: [Bug 131714] Introduce API::FormClient : [Attachment 229412] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 15 15:59:57 PDT 2014


Tim Horton <thorton at apple.com> has granted mitz at webkit.org <mitz at webkit.org>'s
request for review:
Bug 131714: Introduce API::FormClient
https://bugs.webkit.org/show_bug.cgi?id=131714

Attachment 229412: Patch
https://bugs.webkit.org/attachment.cgi?id=229412&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229412&action=review


> Source/WebKit2/UIProcess/API/APIFormClient.h:45
> +    virtual bool willSubmitForm(WebKit::WebPageProxy*,
WebKit::WebFrameProxy*, WebKit::WebFrameProxy* sourceFrame, const
Vector<std::pair<WTF::String, WTF::String>>& textFieldValues, API::Object*
userData, WebKit::WebFormSubmissionListenerProxy*)

do you need the WTF::s here?


More information about the webkit-reviews mailing list