[webkit-reviews] review requested: [Bug 131697] Move DOM timer throttling out of the page throttler : [Attachment 229405] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 15 14:50:16 PDT 2014


Stephanie Lewis <slewis at apple.com> has asked  for review:
Bug 131697: Move DOM timer throttling out of the page throttler
https://bugs.webkit.org/show_bug.cgi?id=131697

Attachment 229405: patch
https://bugs.webkit.org/attachment.cgi?id=229405&action=review

------- Additional Comments from Stephanie Lewis <slewis at apple.com>

DOM timer throttling is currently part of the page throttler which uses per
process state and per page state to determine when to throttle.  This led us to
being overly conservative when turning DOM throttling off.  It should only
respond to view state changes.

Additionally since creating extra Page Throttlers for WebKit1 views and SVG
images caused bugs in tracking state we'll reserve the Page Throttler for
WebKit2 views.	To avoid regressing we should move DOM timer throttling back to
the page.

<rdar://problem/16473004> Throttling DOM timers should be per-page, not
per-process


More information about the webkit-reviews mailing list