[webkit-reviews] review denied: [Bug 129330] [New Multicolumn] Add support for column-span:all : [Attachment 229379] Patch that should get Windows building too.

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 129330: [New Multicolumn] Add support for column-span:all
https://bugs.webkit.org/show_bug.cgi?id=129330

Attachment 229379: Patch that should get Windows building too.
https://bugs.webkit.org/attachment.cgi?id=229379&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229379&action=review


> Source/WebCore/rendering/RenderBlockFlow.cpp:121
> -    moveAllChildrenTo(flowThread, true);
>      RenderBlock::addChild(flowThread);
> +    flowThread->populate();

This part is wrong. By delaying the population of the flow thread until after
the flow thread has been inserted into the flow thread parent, you cause an
anonymous block to be created for no reason to enclose all of the inline
content. This inline content is going into the flow thread, so we don't want to
wastefully wrap it in an unnecessary anonymous block.

(This issue was caught by the client-rects.html layout test on OS X.)