[webkit-reviews] review denied: [Bug 131677] [EFL] Cleanup the build from unused parameters in WebKit-efl : [Attachment 229367] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 15 08:42:16 PDT 2014


Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Jeongeun Kim
<je_julie.kim at samsung.com>'s request for review:
Bug 131677: [EFL] Cleanup the build from unused parameters in WebKit-efl
https://bugs.webkit.org/show_bug.cgi?id=131677

Attachment 229367: Patch
https://bugs.webkit.org/attachment.cgi?id=229367&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229367&action=review


> Source/WebKit/efl/ewk/ewk_network.cpp:-56
> -void ewk_network_tls_certificate_check_set(Eina_Bool checkCertificates)

This isn't to remove only parameter name. This is to remove parameter itself.
So, you have to say why you should change function argument.


More information about the webkit-reviews mailing list