[webkit-reviews] review granted: [Bug 131652] Remove unnecessary null checking in NavigatorContentUtils : [Attachment 229330] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 131652: Remove unnecessary null checking in NavigatorContentUtils
https://bugs.webkit.org/show_bug.cgi?id=131652

Attachment 229330: Patch
https://bugs.webkit.org/attachment.cgi?id=229330&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Frame::document is mostly non-null. If it was truly always non-null then we
(Kling) would have changed it to a Document& instead of a Document* and it
would be clear it doesn’t need null checks.

I think the only times it can be null are very early in the frame lifetime, so
this patch is OK.

But really our goal for the project is to use references for things that can’t
be null so that such things aren’t a matter of style, instead just making it
impossible to include extra null checks.