[webkit-reviews] review denied: [Bug 131662] WTF should have an optional mbmalloc target so we can benchmark FastMalloc : [Attachment 229342] Patch

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 131662: WTF should have an optional mbmalloc target so we can benchmark
FastMalloc
https://bugs.webkit.org/show_bug.cgi?id=131662

Attachment 229342: Patch
https://bugs.webkit.org/attachment.cgi?id=229342&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229342&action=review


> Source/WTF/WTF.xcodeproj/project.pbxproj:328
> +		1447AEBE18FCE56900B3D7FF /* libmbmalloc.dylib */ = {isa =
PBXFileReference; explicitFileType = "compiled.mach-o.dylib"; includeInIndex =
0; path = libmbmalloc.dylib; sourceTree = BUILT_PRODUCTS_DIR; };
> +		1447AEC518FCE57700B3D7FF /* Foundation.framework */ = {isa =
PBXFileReference; lastKnownFileType = wrapper.framework; name =
Foundation.framework; path =
Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Framewor
ks/Foundation.framework; sourceTree = DEVELOPER_DIR; };

These paths need to be SDK-relative, not relative to the developer directory.

> Source/WTF/WTF.xcodeproj/project.pbxproj:1191
> +		1447AEBD18FCE56900B3D7FF /* mbmalloc */ = {

Can you give the target a more descriptive name?

> Source/WTF/WTF.xcodeproj/project.pbxproj:1383
> +			buildSettings = {

These settings all need to live in a .xcconfig file, and should be consistent
with our other targets.