[webkit-reviews] review denied: [Bug 130657] Link underline thickness should be uniform : [Attachment 229233] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Jeongeun Kim
<je_julie.kim at samsung.com>'s request for review:
Bug 130657: Link underline thickness should be uniform
https://bugs.webkit.org/show_bug.cgi?id=130657

Attachment 229233: Patch
https://bugs.webkit.org/attachment.cgi?id=229233&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229233&action=review


> Source/WebCore/rendering/RenderObject.cpp:2145
> +void RenderObject::getTextDecorationColors(int decorations, Color&
underline, Color& overline, Color& linethrough, HashMap<int, RenderStyle*>&
styleMap, bool quirksMode, bool firstlineStyle)

This "int" should more strongly typed. Reading this signature, I have no idea
what the int represents.

I'm also not sure that we want the cost of filling in a HashMap with every call
to this function.