[webkit-reviews] review granted: [Bug 131640] [iOS WK2] Hash table assertion closing a tab : [Attachment 229313] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 14 15:32:26 PDT 2014


Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 131640: [iOS WK2] Hash table assertion closing a tab
https://bugs.webkit.org/show_bug.cgi?id=131640

Attachment 229313: Patch
https://bugs.webkit.org/attachment.cgi?id=229313&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229313&action=review


> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.h:74
> +    HashMap<WebCore::GraphicsLayer::PlatformLayerID, PlatformCALayerRemote*>
m_liveLayers;

"live" might be a misnomer since they're not all in the tree, but whatever.

> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:52
> +    for (auto& keyValuePair : m_liveLayers)

m_liveLayers.values()


More information about the webkit-reviews mailing list