[webkit-reviews] review granted: [Bug 131608] [sh4] SubImmediates can be used in sh4 LLINT : [Attachment 229272] Allow use of SubImmediates in sh4 const pool in LLINT.

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Julien Brianceau
<jbriance at cisco.com>'s request for review:
Bug 131608: [sh4] SubImmediates can be used in sh4 LLINT
https://bugs.webkit.org/show_bug.cgi?id=131608

Attachment 229272: Allow use of SubImmediates in sh4 const pool in LLINT.
https://bugs.webkit.org/attachment.cgi?id=229272&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229272&action=review


r=me

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:747
> +	   if SH4
> +	       flushcp # Force constant pool flush to avoid "pcrel too far"
link error.
> +	   end

I'd be concerned if this proliferates.	Ideally, it's be great if the offline
backend knows to call flushcp automatically when needed without the LLINT
assembly having to explicitly call it like this.  For now, since there's is
only this one use of flushcp (i.e. here), I'll let it go.