[webkit-reviews] review denied: [Bug 131363] [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one : [Attachment 228845] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 14 07:55:52 PDT 2014


Csaba Osztrogonác <ossy at webkit.org> has denied Éva Balázsfalvi
<evab.u-szeged at partner.samsung.com>'s request for review:
Bug 131363: [webkitpy] In case of multiple bug rollout, all bugs should be
reopened, not only the oldest one
https://bugs.webkit.org/show_bug.cgi?id=131363

Attachment 228845: Patch
https://bugs.webkit.org/attachment.cgi?id=228845&action=review

------- Additional Comments from Csaba Osztrogonác <ossy at webkit.org>
The fix looks good to me more or less. 

But after checking it thoroughly, it solves only the case when you rollout
patches with 
webkit-patch rollout, but it doesn't when you do it with webkit-patch
create-rollout.
Sheriffbot uses the create-rollout too, so this code path should be fixed too.


More information about the webkit-reviews mailing list