[webkit-reviews] review granted: [Bug 126322] REGRESSION (r158617): Find on Page can get stuck in a loop when the search string occurs in an <input> in a <fieldset> : [Attachment 229259] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 13 21:53:52 PDT 2014


Ryosuke Niwa <rniwa at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 126322: REGRESSION (r158617): Find on Page can get stuck in a loop when the
search string occurs in an <input> in a <fieldset>
https://bugs.webkit.org/show_bug.cgi?id=126322

Attachment 229259: Patch
https://bugs.webkit.org/attachment.cgi?id=229259&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=229259&action=review


> Source/WebCore/dom/Element.cpp:2944
> +    return !equalIgnoringCase(fastGetAttribute(roleAttr), "img");

Should other element subclasses that override this method check this condition
as well?


More information about the webkit-reviews mailing list