[webkit-reviews] review granted: [Bug 131457] Remove unnecessary uses of std::move() in return statements : [Attachment 228987] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 12 12:36:42 PDT 2014


Darin Adler <darin at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 131457: Remove unnecessary uses of std::move() in return statements
https://bugs.webkit.org/show_bug.cgi?id=131457

Attachment 228987: Patch
https://bugs.webkit.org/attachment.cgi?id=228987&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228987&action=review


> Source/WebCore/platform/RemoteCommandListener.cpp:34
> +    return std::unique_ptr<RemoteCommandListener>(new
RemoteCommandListener(client));

This needs to use make_unique, not unique_ptr/new.

> Source/WebCore/platform/ios/RemoteCommandListenerIOS.mm:44
> +    return std::unique_ptr<RemoteCommandListener>(new
RemoteCommandListenerIOS(client));

This needs to use make_unique, not unique_ptr/new.


More information about the webkit-reviews mailing list