[webkit-reviews] review granted: [Bug 131560] Support document-relative and custom-frame page overlays : [Attachment 229161] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 131560: Support document-relative and custom-frame page overlays
https://bugs.webkit.org/show_bug.cgi?id=131560

Attachment 229161: patch
https://bugs.webkit.org/attachment.cgi?id=229161&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229161&action=review


> Source/WebKit2/WebProcess/WebPage/PageOverlayController.cpp:104
> +    if (overlay->overlayType() == PageOverlay::OverlayType::View) {
> +	   if (Page* page = m_webPage->corePage()) {
> +	       if (ScrollingCoordinator* scrollingCoordinator =
page->scrollingCoordinator())
> +		  
scrollingCoordinator->setForceSynchronousScrollLayerPositionUpdates(true);
> +	   }

Why not just call updateForceSynchronousScrollLayerPositionUpdates()?

> Source/WebKit2/WebProcess/WebPage/PageOverlayController.h:38
> +namespace WebCore {
> +class Frame;
> +}

Remove. You just use WebCore::Frame below.