[webkit-reviews] review granted: [Bug 131497] [iOS][WK2] Videos should animate into and out of fullscreen. : [Attachment 229105] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 131497: [iOS][WK2] Videos should animate into and out of fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=131497

Attachment 229105: Patch
https://bugs.webkit.org/attachment.cgi?id=229105&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229105&action=review


> Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.mm:54
> +static IntRect screenRectOfContents(Node* node)
> +{
> +    if (!node || !node->isElementNode())

Seems like the fullscreen code should be changed to use Element everywhere,
right. Is it even possible to take a non-element node fullscreen?

Better name for the function would be screenRectForNode().