[webkit-reviews] review granted: [Bug 131521] Pipe initial scale factor to TileController : [Attachment 229143] renamed to zoomedOutScale

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 131521: Pipe initial scale factor to TileController
https://bugs.webkit.org/show_bug.cgi?id=131521

Attachment 229143: renamed to zoomedOutScale
https://bugs.webkit.org/attachment.cgi?id=229143&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229143&action=review


> Source/WebCore/platform/graphics/GraphicsLayerClient.h:89
> +    virtual float zoomedOutPageScaleFactor() const { return 0; }

Would getting a zero cause trouble anywhere? (divide-by-zero, etc.)

> Source/WebCore/platform/graphics/TiledBacking.h:92
> +    virtual void setZoomedOutContentsScale(float) = 0;
> +    virtual float zoomedOutContentsScale() const = 0;

Every 'push' property we've had on TileController has caused trouble (and we
have since made many 'pull' via PlatformCALayerClient), but I think this one is
OK because it's called from updateContentsScale. That said, I would not be
opposed to inverting it.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:75
> +typedef int AVPlayerViewControllerExitFullScreenReason;

?