[webkit-reviews] review granted: [Bug 131454] [GTK][WK2] Move Vector objects into WebEditorClient::executePendingEditorCommands() invocations : [Attachment 229110] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 10 23:39:52 PDT 2014


Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 131454: [GTK][WK2] Move Vector objects into
WebEditorClient::executePendingEditorCommands() invocations
https://bugs.webkit.org/show_bug.cgi?id=131454

Attachment 229110: Patch
https://bugs.webkit.org/attachment.cgi?id=229110&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229110&action=review


Please update also the header to fix the build.

> Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:50
> +bool WebEditorClient::executePendingEditorCommands(Frame* frame, const
Vector<WTF::String>& pendingEditorCommands, bool allowTextInsertion)

You need to update the header too.


More information about the webkit-reviews mailing list