[webkit-reviews] review denied: [Bug 131521] Pipe initial scale factor to TileController : [Attachment 229097] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 131521: Pipe initial scale factor to TileController
https://bugs.webkit.org/show_bug.cgi?id=131521

Attachment 229097: patch
https://bugs.webkit.org/attachment.cgi?id=229097&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229097&action=review


> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2989
> +    if (tiledBacking()) {
> +	   float initialScale = (m_client ? m_client->initialPageScaleFactor()
: 1) * deviceScaleFactor();
> +	   tiledBacking()->setInitialContentsScale(initialScale);
> +    }

This seems like an odd way to get initial scale, and could easily have timing
issues. I think we should explicitly get the initial scale from
viewport-related information.