[webkit-reviews] review granted: [Bug 131478] Move early return out of dispatch_async() block so we can return from willSendRequest quickly : [Attachment 229084] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 131478: Move early return out of dispatch_async() block so we can return
from willSendRequest quickly
https://bugs.webkit.org/show_bug.cgi?id=131478

Attachment 229084: Patch
https://bugs.webkit.org/attachment.cgi?id=229084&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=229084&action=review


I'm not sure if we need to follow the Mac pattern with secondary threads at all
- it looks like CFURLConnection may have all the async delegates we could wish
for.

If that's feasible, that should be much better, and would make this patch
unnecessary.

>
Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOpe
rationQueue.cpp:86
> +    if (!originalRedirectResponse) {
> +	   RetainPtr<CFStringRef> newScheme =
adoptCF(CFURLCopyScheme(CFURLRequestGetURL(cfRequest)));
> +	   if (CFStringCompare(newScheme.get(), m_originalScheme.get(),
kCFCompareCaseInsensitive) == kCFCompareEqualTo) {
> +	       CFRetain(cfRequest);
> +	       return cfRequest;
> +	   }
> +    }

Shouldn't this code be removed from synthesizeRedirectResponseIfNecessary()
now?

Would also be good to move a comment about HSTS here.