[webkit-reviews] review granted: [Bug 131493] [iOS WebKit2] Support phraseboundary gesture recognizer for CJK : [Attachment 229053] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 131493: [iOS WebKit2] Support phraseboundary gesture recognizer for CJK
https://bugs.webkit.org/show_bug.cgi?id=131493

Attachment 229053: Patch
https://bugs.webkit.org/attachment.cgi?id=229053&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=229053&action=review


> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1492
> +	       static const uint32_t kHitAreaWidth = 66;
> +	       static const uint32_t kHitAreaHeight = 66;

They should not be static. (although I am curious if the compiler would
optimize it out).

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1493
> +	       FrameView* view = frame.view();

Let's use a reference to make Andreas happy.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1506
> +	       float deltaX = ABS(caretRect.x() + (caretRect.width() / 2) -
point.x());
> +	       float deltaYFromTheTop = ABS(caretRect.y() - point.y());
> +	       float deltaYFromTheBottom = ABS(caretRect.y() +
caretRect.height() - point.y());

Let's use the std abs.