[webkit-reviews] review denied: [Bug 131452] Avoid Vector copies in RenderGrid::placeItemsOnGrid() : [Attachment 228982] Patch

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 131452: Avoid Vector copies in RenderGrid::placeItemsOnGrid()
https://bugs.webkit.org/show_bug.cgi?id=131452

Attachment 228982: Patch
https://bugs.webkit.org/attachment.cgi?id=228982&action=review

------- Additional Comments from Sergio Villar Senin <svillar at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228982&action=review


> Source/WebCore/ChangeLog:9
> +	   placeAutoMajorAxisItemsOnGrid() methods which take the vectors by
value.

There is actually no reason to pass them by value. Let's just use references
there. Actually we should use const references as the vectors are not modified
at all.