[webkit-reviews] review denied: [Bug 131478] Move early return out of dispatch_async() block so we can return from willSendRequest quickly : [Attachment 229025] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 131478: Move early return out of dispatch_async() block so we can return
from willSendRequest quickly
https://bugs.webkit.org/show_bug.cgi?id=131478

Attachment 229025: Patch
https://bugs.webkit.org/attachment.cgi?id=229025&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=229025&action=review


> Source/WebCore/ChangeLog:9
> +	   We can do a check for redirect response on the dispatch queue and
return from willSendRequest

synthesizeRedirectResponseIfNecessary uses ResourceRequest class, which is not
thread safe. The Foundation version of this function doesn't do that, so it's
safe to call on a secondary thread.

Good catch though, perhaps we can refactor the code to make this fix work.