[webkit-reviews] review denied: [Bug 99037] [GStreamer] No CORS support for media elements : [Attachment 227281] fixed nullptr style issue

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied youenn fablet
<youennf at gmail.com>'s request for review:
Bug 99037: [GStreamer] No CORS support for media elements
https://bugs.webkit.org/show_bug.cgi?id=99037

Attachment 227281: fixed nullptr style issue
https://bugs.webkit.org/attachment.cgi?id=227281&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227281&action=review


Looks quite good, thanks! We just need a final iteration I think :)

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:841
> +	       GST_ELEMENT_ERROR(src, RESOURCE, READ, ("%s", "Cross-origin
stream load denied by Cross-Origin Resource Sharing policy."), (nullptr));

What is the %s for there?

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1040
> +    // FIXME: In case of PotentiallyCrossOriginEnabled policy, preflight
mode should sometimes be used (not simple request headers).
> +    // But CachedResourceLoader does not support it. Use
DocumentThreadableLoader instead?

Can you please file a new bug for this and mention it in the comment?