[webkit-reviews] review granted: [Bug 131465] Eliminate DragSession structure : [Attachment 229001] proposed patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 131465: Eliminate DragSession structure
https://bugs.webkit.org/show_bug.cgi?id=131465

Attachment 229001: proposed patch
https://bugs.webkit.org/attachment.cgi?id=229001&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=229001&action=review


Looks great.

> Source/WebCore/page/DragController.h:65
> +	   // As computed from the most recent DragData.

Not sure the comment is useful. That is pretty much true for all the state of
DragController.

> Source/WebKit2/UIProcess/WebPageProxy.h:905
> +    void resetCurrentDragInformation() { m_currentDragOperation =
WebCore::DragOperationNone; m_currentDragIsOverFileInput = false;
m_currentDragNumberOfFilesToBeAccepted = 0; }

Let's put this in the cpp file or split it over 3 lines.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:2251
> +    NSInteger numberOfValidItemsForDrop =
_data->_page->currentDragNumberOfFilesToBeAccepted();

No need for cast here?

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2783
> +    DragOperation resolvedDragOperation;

It may be better to create a scope for both cases and define
resolvedDragOperation in there.