[webkit-reviews] review granted: [Bug 131451] Don't offer "contact" actions in telephone number menus : [Attachment 228981] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 9 14:14:03 PDT 2014


Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 131451: Don't offer "contact" actions in telephone number menus
https://bugs.webkit.org/show_bug.cgi?id=131451

Attachment 228981: Patch v1
https://bugs.webkit.org/attachment.cgi?id=228981&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228981&action=review


> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:674
> +	   if ([[actionObject actionUTI]
rangeOfString:@"com.apple.contact."].location == 0)

hasPrefix?

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:678
> +	   if ([actionObject isKindOfClass:[getDDSeparatorActionClass()
class]])

Isn't it already a Class? Why +class? Same above.


More information about the webkit-reviews mailing list