[webkit-reviews] review granted: [Bug 131402] AX: Initial text selection point should respect element focus. : [Attachment 228906] Patch.

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Samuel White
<samuel_white at apple.com>'s request for review:
Bug 131402: AX: Initial text selection point should respect element focus.
https://bugs.webkit.org/show_bug.cgi?id=131402

Attachment 228906: Patch.
https://bugs.webkit.org/attachment.cgi?id=228906&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228906&action=review


> LayoutTests/platform/mac/accessibility/selection-initial.html:88
> +	   //

This should just be one line I think

> LayoutTests/platform/mac/accessibility/selection-initial.html:131
> +	   //

ditto

> Source/WebCore/page/EventHandler.cpp:3049
> +static void setKeyboardSelection(Frame& frame, SelectionDirection direction)


should this be setInitialKeyboardSelection

> Source/WebCore/page/EventHandler.cpp:3052
> +

you can remove this empty line

> Source/WebCore/ChangeLog:10
> +	   Added function to set initial selection more gracefully.
Specifically, when accessibility has the need to set initial selection,

move this explanation above the line about "No New Tests'

This should say something like
"Support the case where we want to set the initial selection and there's
already a focused element."
The current wording is a bit backward in terms of importance