[webkit-reviews] review granted: [Bug 131426] AX: Make AXPress much more reliable on the Web : [Attachment 228947] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 9 07:52:40 PDT 2014


Mario Sanchez Prada <mario at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 131426: AX: Make AXPress much more reliable on the Web
https://bugs.webkit.org/show_bug.cgi?id=131426

Attachment 228947: patch
https://bugs.webkit.org/attachment.cgi?id=228947&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=228947&action=review


> Source/WebCore/accessibility/AccessibilityObject.cpp:42
> +#include "HitTestResult.h"

This placement seems to make the style checker unhappy

> Source/WebCore/accessibility/AccessibilityObject.cpp:723
> +    // The presencen of the actionElement will confirm whether we should
even attempt a press.

s/presencen/presence

> Source/WebCore/accessibility/AccessibilityObject.cpp:750
> +    Element* element = this->element();
> +    Element* pressElement = element;

You can use just one variable here, pressElement, assigned to this->element()


More information about the webkit-reviews mailing list