[webkit-reviews] review requested: [Bug 131380] [GTK] Layout tests accessibility/children-changed-sends-notification.html and accessibility/notification-listeners.html fails : [Attachment 228962] Patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 9 07:37:28 PDT 2014


Mario Sanchez Prada <mario at webkit.org> has asked  for review:
Bug 131380: [GTK] Layout tests
accessibility/children-changed-sends-notification.html and
accessibility/notification-listeners.html fails
https://bugs.webkit.org/show_bug.cgi?id=131380

Attachment 228962: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=228962&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
Interestingly enough, we were avoiding to send the "add" signal for objects
whose parents (where the signal will be emitted from) we knew in advance were
not going to be exposed, but we did still emit the signal when the actual
object being added would not be exposed, which is non sense.

We only should emit the add signal when both the object being added AND its
parent are known not to be ignored from the accessibility tree.

Pleas review


More information about the webkit-reviews mailing list