[webkit-reviews] review requested: [Bug 130386] AX: Bug in AccessibilityNodeObject::helpText : [Attachment 228945] patch with review feedback

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 8 23:34:48 PDT 2014


James Craig <jcraig at apple.com> has asked  for review:
Bug 130386: AX: Bug in AccessibilityNodeObject::helpText
https://bugs.webkit.org/show_bug.cgi?id=130386

Attachment 228945: patch with review feedback
https://bugs.webkit.org/attachment.cgi?id=228945&action=review

------- Additional Comments from James Craig <jcraig at apple.com>
Stylistic change based on review feedback. Avoids extra conditional here (and
simplifies code) for the element case even if it causes slightly more execution
(conditionals embedded in getAttribute, etc) in the less common, non-element
case.


More information about the webkit-reviews mailing list