[webkit-reviews] review requested: [Bug 131427] [EFL] Change font path for DumpRenderTree and WebKitTestRunner : [Attachment 228935] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked  for review:
Bug 131427: [EFL] Change font path for DumpRenderTree and WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=131427

Attachment 228935: Patch
https://bugs.webkit.org/attachment.cgi?id=228935&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228935&action=review


> Tools/DumpRenderTree/PlatformEfl.cmake:78
>  # FIXME: DOWNLOADED_FONTS_DIR should not hardcode the directory

BTW, I think we can delete this FIXME: comment. Bug 81475 was closed.

>>> Tools/DumpRenderTree/PlatformEfl.cmake:80
>>> +add_definitions(-DFONTS_CONF_DIR="${TOOLS_DIR}/WebKitTestRunner/gtk/fonts"

>> 
>> I think this change occurred because GTK port is deleting their wk1 port.
However, we decide to keep wk1 port. It looks that now is time to have EFL own
font directory path.
> 
> Yes, after removed GtKLauncher, fonts are just moved to
WebKitTestRunner/gtk/fonts.
> I don't think that it is good to copy them to efl specific folder.
> And we don't have good fonts for efl port yet.
> 
> One solution is moving fonts to better place but I don't have idea.

I think we need to add a comment. For example,

"FIXME: EFL port needs to have own test font and font configure instead of gtk
test font in future"

> Tools/WebKitTestRunner/PlatformEfl.cmake:79
>  # FIXME: DOWNLOADED_FONTS_DIR should not hardcode the directory

ditto.